fix: use float division for success ratio calculation (fixes #1163) - #1228
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: use float division for success ratio calculation (fixes #1163)#1228AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
AruneshDwivedi
requested review from
ashnamehrotra,
pmengelbert and
sozercan
as code owners
August 9, 2026 11:17
…ev#1163) The success ratio calculation used integer division: float64(successAndSkipped/imageJob.Status.Desired) This means 273/273 = 1 (integer division), but 272/273 = 0 (integer division), causing the job to incorrectly fail even with 99%+ success. The fix: cast to float64 before division: float64(successAndSkipped)/float64(imageJob.Status.Desired) Also fixes the log output which had the same integer division bug. Fixes eraser-dev#1163 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
AruneshDwivedi
force-pushed
the
fix/issue-1163-integer-division
branch
from
August 12, 2026 09:00
3a07d39 to
be6d070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1163
The success ratio calculation used integer division:
float64(successAndSkipped/imageJob.Status.Desired)
This means 273/273 = 1 (integer division), but 272/273 = 0 (integer division),
causing the job to incorrectly fail even with 99%+ success.
The fix: cast to float64 before division:
float64(successAndSkipped)/float64(imageJob.Status.Desired)
Also fixes the log output which had the same integer division bug.