feat: add accessible closeLabel prop to Badge close button#108
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an explicit accessible label for the Badge close button and wires it through ResourceBadge, updating the UI package version and component docs accordingly.
Changes:
- Add
closeLabelprop toBadgeand apply it asaria-labelon the close button. - Thread
closeLabelthroughResourceBadgeto the underlyingBadge. - Update MDX documentation and bump
@eqtylab/equalityversion to2.2.2.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/src/components/resource-badge/resource-badge.tsx | Adds closeLabel prop and forwards it to Badge. |
| packages/ui/src/components/badge/badge.tsx | Introduces closeLabel and uses it for the close button’s aria-label. |
| packages/ui/package.json | Bumps package version to 2.2.2. |
| packages/demo/src/content/components/resource-badge.mdx | Documents new closeLabel prop for ResourceBadge. |
| packages/demo/src/content/components/badge.mdx | Documents new closeLabel prop for Badge. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.