feat: add forecast_multivariate_point class#1115
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
==========================================
+ Coverage 97.87% 97.95% +0.07%
==========================================
Files 35 37 +2
Lines 1881 1953 +72
==========================================
+ Hits 1841 1913 +72
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Review of PR #1115Overall this is a clean implementation that follows existing patterns well. A few items to consider: Unnecessary nolint comments
Inherited docs mismatch
transform-forecasts.R changeThe generalisation from hardcoded Everything else looks good
|
- Remove unnecessary line_length_linter nolint - Replace inherited param docs with point-forecast-specific descriptions - Add test for check_input_point failure path (coverage) - Add NEWS.md entry
- Extract ensure_mv_grouping() for shared constructor logic - Extract score_multivariate_apply() for shared scoring logic - Use @inheritParams for joint_across and forecast_unit docs - Simplify transform_forecasts.R to single constructor call path
seabbs
left a comment
There was a problem hiding this comment.
This looks good to me. Note a few related issues.
|
@nickreich for awareness |
Summary
forecast_multivariate_pointclass with constructor, assertion, scoring, and metric methods following theforecast_multivariate_samplepatternvariogram_score_multivariate_point()metric that wrapsscoringRules::vs_sample()treating point forecasts as single-sample ensemblestransform_forecasts()to correctly dispatch multivariate point types when recomputing.mv_group_idCloses #1112
Test plan
is_forecast_multivariate_point()positive/negative checksget_metrics()returns expected metric listscore()produces numeric variogram scores with snapshot outputjoint_acrossand invalid columnsThis was opened by a bot. Please ping @seabbs for any questions.