Skip to content

Comments

BOT: Fix #785: Update scoring rules vignette#1088

Draft
nikosbosse wants to merge 1 commit intomainfrom
fix/785-scoring-rules-vignette-updates
Draft

BOT: Fix #785: Update scoring rules vignette#1088
nikosbosse wants to merge 1 commit intomainfrom
fix/785-scoring-rules-vignette-updates

Conversation

@nikosbosse
Copy link
Collaborator

Summary

  • Addresses review feedback from PR Issue #758 - Update metrics vignette #762 on vignettes/scoring-rules.Rmd
  • Removes author field from YAML header
  • Replaces Google Drive paper link with reference to package documentation and Bosse et al. (2022) citation
  • Adds reference for proper scoring rules (Gneiting & Raftery 2007) and fixes LaTeX \citep{} to pandoc citation syntax
  • Improves get_metrics wording for website readers across all forecast type sections
  • Removes extra whitespace after code block
  • Adds introductory paragraph explaining different probabilistic forecast formats (binary, sample-based, quantile-based)
  • Fixes incorrect "point forecasts" labels in binary forecasts section
  • Adds Bosse et al. (2022) entry to bibliography

Fixes #785

Test plan

  • Vignette renders without errors
  • R CMD check: 0 errors, 0 warnings, 2 notes (pre-existing)
  • All existing tests pass

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (ac0c01a) to head (6035fc2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          35       35           
  Lines        1845     1845           
=======================================
  Hits         1805     1805           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator Author

@nikosbosse nikosbosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLAUDE: The vignette edits are well-done and address most of the PR #762 review feedback correctly. However, the new bibliography entry for Bosse et al. (2022) has wrong author names and must be fixed before merging.

Critical issue: The @bosseEvaluatingForecastsEpidemiological2022 entry in scoringutils-package.bib lists authors as Grber, Hugo and Jordan, Alexander and Krger, Fabian but the actual authors of arXiv:2205.07090 are:

Bosse, Nikos I. and Gruson, Hugo and Cori, Anne and van Leeuwen, Edwin and Funk, Sebastian and Abbott, Sam

"Jordan, Alexander" and "Krüger, Fabian" are not authors of this paper. "Grber" appears to be a mangled "Gruson" (not "Grüber").

Minor: The "ref to transformed scores paper?" suggestion from @seabbs was not addressed, but this could be deferred.

All other changes (author removal, Google Drive link replacement, Gneiting 2007 citation, \citep[@] fix, get_metrics wording, whitespace cleanup, intro paragraph, "point forecasts" → "binary forecasts" fix) are correct and well-executed.

Verdict: request changes — fix the bib entry author list before merging.

@nikosbosse nikosbosse marked this pull request as draft February 13, 2026 08:27
@nikosbosse nikosbosse changed the title Fix #785: Update scoring rules vignette BOT: Fix #785: Update scoring rules vignette Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small updates to the scoring rules Vignette

1 participant