BOT: Fix #785: Update scoring rules vignette#1088
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 35 35
Lines 1845 1845
=======================================
Hits 1805 1805
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nikosbosse
left a comment
There was a problem hiding this comment.
CLAUDE: The vignette edits are well-done and address most of the PR #762 review feedback correctly. However, the new bibliography entry for Bosse et al. (2022) has wrong author names and must be fixed before merging.
Critical issue: The @bosseEvaluatingForecastsEpidemiological2022 entry in scoringutils-package.bib lists authors as Grber, Hugo and Jordan, Alexander and Krger, Fabian but the actual authors of arXiv:2205.07090 are:
Bosse, Nikos I. and Gruson, Hugo and Cori, Anne and van Leeuwen, Edwin and Funk, Sebastian and Abbott, Sam
"Jordan, Alexander" and "Krüger, Fabian" are not authors of this paper. "Grber" appears to be a mangled "Gruson" (not "Grüber").
Minor: The "ref to transformed scores paper?" suggestion from @seabbs was not addressed, but this could be deferred.
All other changes (author removal, Google Drive link replacement, Gneiting 2007 citation, \citep → [@] fix, get_metrics wording, whitespace cleanup, intro paragraph, "point forecasts" → "binary forecasts" fix) are correct and well-executed.
Verdict: request changes — fix the bib entry author list before merging.
Summary
vignettes/scoring-rules.Rmd\citep{}to pandoc citation syntaxget_metricswording for website readers across all forecast type sectionsFixes #785
Test plan
🤖 Generated with Claude Code