BOT: Fix #807: Clean up linter statements around cli conditions#1086
BOT: Fix #807: Clean up linter statements around cli conditions#1086nikosbosse wants to merge 1 commit intomainfrom
Conversation
…uoted equivalents Replace all `"!" =`, `"i" =`, `"x" =`, `"v" =` patterns in cli_abort/cli_warn/cli_inform calls with backtick-quoted equivalents (`!` =, `i` =, etc.) across 17 R source files. Remove all keyword_quote_linter nolint annotations (keeping other linter suppressions where needed). Enable keyword_quote_linter by removing its NULL exclusion from .lintr. Add regression tests to prevent reintroduction of double-quoted cli condition names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 35 35
Lines 1845 1845
=======================================
Hits 1805 1805
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nikosbosse
left a comment
There was a problem hiding this comment.
CLAUDE: Approved. Clean, mechanical fix that correctly replaces all 53 double-quoted cli condition names with backtick-quoted equivalents across 17 R source files, removes/simplifies all associated nolint blocks, re-enables keyword_quote_linter in .lintr, and adds 5 well-designed regression tests. All nolint start/end blocks are properly balanced, no remaining double-quoted patterns, and combo blocks correctly simplified to retain only still-needed linters. No issues found.
Summary
"!" =,"i" =,"x" =,"v" =) with backtick-quoted equivalents (`!` =,`i` =, etc.) across 17 R source files (53 occurrences)keyword_quote_linternolint annotations (~28 blocks), keeping other linter suppressions (object_usage_linter,duplicate_argument_linter) where still neededkeyword_quote_linterby removing itsNULLexclusion from.lintrRoot cause
The
keyword_quote_linterwas disabled in.lintrand suppressed with#nolintblocks because cli condition names like"!" =were flagged as unnecessary quotes. The fix is to use backtick-quoted names (`!` =), which are semantically identical to cli but satisfy the linter.Test plan
keyword_quote_linternolint annotations remainkeyword_quote_linteris not disabled in.lintrFixes #807
🤖 Generated with Claude Code