BOT: Fix #922: Remove check_columns_present and test_columns_present#1080
Draft
nikosbosse wants to merge 1 commit intomainfrom
Draft
BOT: Fix #922: Remove check_columns_present and test_columns_present#1080nikosbosse wants to merge 1 commit intomainfrom
nikosbosse wants to merge 1 commit intomainfrom
Conversation
Replace all 10 call sites of check_columns_present (and 1 of test_columns_present) with equivalent checkmate functions (assert_subset, check_subset, test_subset), then delete both functions and their man pages. checkmate is already a dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
- Coverage 97.83% 97.80% -0.03%
==========================================
Files 35 35
Lines 1845 1826 -19
==========================================
- Hits 1805 1786 -19
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nikosbosse
commented
Feb 13, 2026
Collaborator
Author
nikosbosse
left a comment
There was a problem hiding this comment.
CLAUDE: Clean, well-scoped removal of check_columns_present and test_columns_present, replaced by equivalent checkmate functions (check_subset, assert_subset, test_subset). All 11 call sites correctly handle argument order reversal and preserve identical runtime semantics. All 672 tests pass. No issues found. Verdict: approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_columns_present()and 1 call site oftest_columns_present()with equivalentcheckmatefunctions (assert_subset,check_subset,test_subset)Fixes #922
Root cause
check_columns_present()andtest_columns_present()are custom internal functions that duplicate functionality already provided bycheckmate::check_subset()/checkmate::test_subset()/checkmate::assert_subset(), which is already a package dependency.What was changed
check_columns_present()andtest_columns_present()function definitionsassert(check_columns_present(...))→assert_subset(...),test_columns_present(...)→test_subset(...)assert(check_columns_present(...))→assert_subset(...)assert(check_columns_present(...))→assert_subset(...)assert(check_columns_present(...))→assert_subset(...)assert(check_columns_present(...))→assert_subset(...)assert(check_columns_present(...))→assert_subset(...)assert(check_columns_present(...))→assert_subset(...),check_columns_present(...)→check_subset(...)assert(check_columns_present(...))→assert_subset(...)check_columns_present(...)→check_subset(...)check_columns_present.Rdandtest_columns_present.RdTest plan
🤖 Generated with Claude Code