Fix quota result when all limits were exceeded#1059
Open
yanavlasov wants to merge 4 commits intoenvoyproxy:mainfrom
Open
Fix quota result when all limits were exceeded#1059yanavlasov wants to merge 4 commits intoenvoyproxy:mainfrom
yanavlasov wants to merge 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: yavlasov <yavlasov@google.com>
Author
|
@yuzisun for initial review |
Author
|
Need to rework the mixed mode. Will ping when it is ready for review. |
yuzisun
approved these changes
Feb 8, 2026
integration-test/scripts/quota.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| echo "Wating 1 minute for quota buckets to be refreshed" |
Contributor
There was a problem hiding this comment.
Suggested change
| echo "Wating 1 minute for quota buckets to be refreshed" | |
| echo "Waiting 1 minute for quota buckets to be refreshed" |
integration-test/scripts/quota.sh
Outdated
|
|
||
| response=$(curl -i -s http://envoy-proxy:8888/quota) | ||
| if [ $? -ne 0 ]; then | ||
| echo "Quota bucket should be refereshed" |
Contributor
There was a problem hiding this comment.
Suggested change
| echo "Quota bucket should be refereshed" | |
| echo "Quota bucket should be refreshed" |
yuzisun
reviewed
Feb 9, 2026
src/service/ratelimit.go
Outdated
| response.Statuses = make([]*pb.RateLimitResponse_DescriptorStatus, len(request.Descriptors)) | ||
| finalCode := pb.RateLimitResponse_OK | ||
| if isQuotaMode { | ||
| finalCode = pb.RateLimitResponse_OVER_LIMIT |
Contributor
There was a problem hiding this comment.
Could this behavior be configurable and default to reject ? we may still want to send out and let cloud provider reject as the quota tracking in envoy is best effort and the quota enforcement window may not be exactly aligned with the cloud provider.
Author
There was a problem hiding this comment.
This looks like what shadow mode is doing, unless I misunderstand it.
Signed-off-by: yavlasov <yavlasov@google.com>
Signed-off-by: yavlasov <yavlasov@google.com>
Signed-off-by: yavlasov <yavlasov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix results in quota mode when all limits have been exceeded. In this case request should be denied.
Also add starter integration tests for quota mode.