Skip to content

reverse tunnels: add formatters to handshake config#45648

Open
AntonKanug wants to merge 1 commit into
envoyproxy:mainfrom
AntonKanug:antonk/rt-formatters
Open

reverse tunnels: add formatters to handshake config#45648
AntonKanug wants to merge 1 commit into
envoyproxy:mainfrom
AntonKanug:antonk/rt-formatters

Conversation

@AntonKanug

Copy link
Copy Markdown
Contributor

Specific use case is that using secrets from SDS for additional_headers in http handshake config

similar to #44599

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #45648 was opened by AntonKanug.

see: more, trace.

#include <string>

#include "envoy/formatter/substitution_formatter_base.h"
#include "envoy/formatter/substitution_formatter.h"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaks build, just here until main is fixed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonKanug AntonKanug force-pushed the antonk/rt-formatters branch 4 times, most recently from 50bace9 to ae092e6 Compare June 15, 2026 23:11
@AntonKanug AntonKanug marked this pull request as ready for review June 15, 2026 23:21
@repokitteh-read-only

Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #45648 was ready_for_review by AntonKanug.

see: more, trace.

Signed-off-by: Anton Kanugalawattage <antonk@palantir.com>
@AntonKanug AntonKanug force-pushed the antonk/rt-formatters branch from ae092e6 to 9d9ebb2 Compare June 15, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants