chore(deps): bump `rand_core` to `0.10.0-rc-5` by baloo · Pull Request #108 · entropyxyz/crypto-primes

baloo · 2026-01-19T20:01:46Z

Depends:

Update rand_core to 0.10.0-rc-4 rust-random/rand#1712

codecov · 2026-01-19T20:04:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.93%. Comparing base (41b60a9) to head (0101887).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   97.93%   97.93%   -0.01%     
==========================================
  Files          14       14              
  Lines        1893     1891       -2     
==========================================
- Hits         1854     1852       -2     
  Misses         39       39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tarcieri · 2026-01-19T20:09:29Z

Note: I'll have a crypto-bigint update out here shortly

baloo · 2026-01-19T21:09:10Z

I don't know if we need a bump of crypto-bigint. I think this is enough, at least it's enough for RSA to bump to rand_core 0.10.0-rc-4

tarcieri · 2026-01-19T21:14:13Z

I'm maybe a half hour away.

I think it's good if the versions are in lockstep. There hopefully aren't any breaking changes but it'd be good to know for sure.

tarcieri · 2026-01-19T21:50:04Z

It's out: https://crates.io/crates/crypto-bigint/0.7.0-rc.19

Hopefully doesn't break anything but it'd be good to know and get included along with bumping everything else.

I can try it out on your branch if you want.

(I can look in a bit, seems it broke something in elliptic-curve)

tarcieri · 2026-01-19T22:14:34Z

Ugh, ran into some breakages in crypto-bigint and I'll be cutting another release

baloo · 2026-01-19T22:14:43Z

There is some amount of breakage in crypto-bigint I have to spend some time on it.

baloo · 2026-01-19T22:15:04Z

Ugh, ran into some breakages in crypto-bigint and I'll be cutting another release

ha.

tarcieri · 2026-01-19T23:27:50Z

crypto-bigint v0.7.0-rc.20 is out

baloo · 2026-01-20T00:12:49Z

For some reason it would not find the AsRef<[Limb]> implementation anymore (or it had multiple alternative AsRef), I've switched to using as_limbs instead.

tarcieri · 2026-01-20T00:20:04Z

@baloo this release added an overlapping impl: AsRef<UintRef> (and AsMut<UintRef>) so inference no longer works like it did before, unfortunately.

Maybe we should remove the AsRef<[Limb]> impl and people can either use .as_limbs() or .as_ref().as_limbs().

tarcieri · 2026-01-20T18:27:55Z

@fjarri can you take a look at this one? Unfortunately it's more breaking changes that block upgrading everything else

fjarri · 2026-01-20T18:38:23Z

 harness = false
+
+[patch.crates-io]
+rand = { git = "https://github.com/rust-random/rand.git" }


Is it still necessary?

Sadly yes. This is only used to run tests though. There was some amount of API breakage between rand_core rc-3 and rc-5.

Yeah, there hasn't been a new rand release yet. But, since it's a dev-dependency, it won't block publishing a new prerelease

Could you pin the revision, just so that it doesn't break stuff in future runs?

Sidebar: that's what Cargo.lock is for! 😜

I admit I am not entirely sure if it bumps the revision automatically when the new one is available.

I don't believe any dependency management robot supports that.

fjarri · 2026-01-20T19:03:33Z

Do you need a new release with this?

tarcieri · 2026-01-20T19:04:46Z

Yes that'd be great, thanks!

* chore(deps): bump `rand_core` to `0.10.0-rc-5` * chore(deps): bump `crypto-bigint` to `0.7.0-pre.21`

baloo force-pushed the baloo/push-zlqkpkvxqksw branch from d7ce29a to 047afeb Compare January 19, 2026 21:07

baloo mentioned this pull request Jan 19, 2026

chore(deps): bump rand_core to 0.10.0-rc-5 RustCrypto/RSA#632

Merged

baloo mentioned this pull request Jan 19, 2026

chore(deps): bump rand_core to 0.10.0-rc-5 RustCrypto/SSH#453

Merged

baloo mentioned this pull request Jan 19, 2026

chore(deps): bump rand_core to 0.10.0-rc-5 RustCrypto/signatures#1161

Merged

baloo force-pushed the baloo/push-zlqkpkvxqksw branch from 047afeb to f1a4df5 Compare January 20, 2026 00:11

baloo force-pushed the baloo/push-zlqkpkvxqksw branch 2 times, most recently from 68aec46 to 266af98 Compare January 20, 2026 15:23

baloo changed the title ~~chore(deps): bump rand_core to 0.10.0-rc-4~~ chore(deps): bump rand_core to 0.10.0-rc-5 Jan 20, 2026

baloo marked this pull request as ready for review January 20, 2026 15:23

baloo force-pushed the baloo/push-zlqkpkvxqksw branch from 266af98 to c9428e3 Compare January 20, 2026 15:31

chore(deps): bump rand_core to 0.10.0-rc-5

bf0cecb

baloo force-pushed the baloo/push-zlqkpkvxqksw branch from c9428e3 to bf0cecb Compare January 20, 2026 17:35

tarcieri reviewed Jan 20, 2026

View reviewed changes

Comment thread Cargo.toml Outdated

tarcieri reviewed Jan 20, 2026

View reviewed changes

Comment thread Cargo.toml Outdated

chore(deps): bump crypto-bigint to 0.7.0-pre.21

0101887

baloo force-pushed the baloo/push-zlqkpkvxqksw branch from 7e75f6e to 0101887 Compare January 20, 2026 18:35

fjarri reviewed Jan 20, 2026

View reviewed changes

fjarri merged commit e873d92 into entropyxyz:master Jan 20, 2026
12 checks passed

baloo deleted the baloo/push-zlqkpkvxqksw branch January 21, 2026 03:40

takumi-earth pushed a commit to earthlings-dev/crypto-primes that referenced this pull request Jan 27, 2026

chore(deps): bump rand_core to 0.10.0-rc-5 (entropyxyz#108)

33de550

* chore(deps): bump `rand_core` to `0.10.0-rc-5` * chore(deps): bump `crypto-bigint` to `0.7.0-pre.21`

Conversation

baloo commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tarcieri commented Jan 19, 2026

Uh oh!

baloo commented Jan 19, 2026

Uh oh!

tarcieri commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarcieri commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarcieri commented Jan 19, 2026

Uh oh!

baloo commented Jan 19, 2026

Uh oh!

baloo commented Jan 19, 2026

Uh oh!

tarcieri commented Jan 19, 2026

Uh oh!

baloo commented Jan 20, 2026

Uh oh!

tarcieri commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

tarcieri commented Jan 20, 2026

Uh oh!

fjarri Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

baloo Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

tarcieri Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

fjarri Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

tarcieri Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

fjarri Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

baloo Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fjarri commented Jan 20, 2026

Uh oh!

tarcieri commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

baloo commented Jan 19, 2026 •

edited

Loading

codecov Bot commented Jan 19, 2026 •

edited

Loading

tarcieri commented Jan 19, 2026 •

edited

Loading

tarcieri commented Jan 19, 2026 •

edited

Loading

baloo Jan 20, 2026 •

edited

Loading