Fix Tide Chart gTrade resolve-pair asset summary#46
Open
dive2tech wants to merge 1 commit intoentrius:mainfrom
Open
Fix Tide Chart gTrade resolve-pair asset summary#46dive2tech wants to merge 1 commit intoentrius:mainfrom
dive2tech wants to merge 1 commit intoentrius:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Tide Chart gTrade resolve-pair endpoint so it uses a supported SynthClient API and reliably returns the current asset price for the frontend.
Related Issues
#45
Type of Change
Changes
get_asset_summary(asset, horizon)toSynthClientto expose a small, typed snapshot includingasset,horizon, andcurrent_price, backed byget_prediction_percentiles./api/gtrade/resolve-pairin the Tide Chart server to callclient.get_asset_summary(asset, horizon="24h")instead of a non-existent client method, and to always return a stable JSON shape withasset,pair_index, andcurrent_price.get_asset_summaryhelper, including validation of asset and horizon inputs./api/gtrade/resolve-pairroute, asserting thatcurrent_priceis present and numeric when mock Synth data is available.Testing
synth_client:tests/test_synth_client.py::test_get_asset_summary_returns_current_pricetests/test_synth_client.py::test_get_asset_summary_rejects_unsupported_assettests/test_synth_client.py::test_get_asset_summary_rejects_unsupported_horizontools/tide-chart/tests/test_tool.py::test_flask_gtrade_resolve_pair_validRun: