Skip to content

Comments

fix: missing separator in MinerEvaluationCache.get() log message#200

Merged
anderdc merged 6 commits intoentrius:testfrom
njlazzar-su:fix/cache-log-message
Feb 20, 2026
Merged

fix: missing separator in MinerEvaluationCache.get() log message#200
anderdc merged 6 commits intoentrius:testfrom
njlazzar-su:fix/cache-log-message

Conversation

@njlazzar-su
Copy link
Contributor

Summary

Fix malformed log message in MinerEvaluationCache.get() when a cache identity mismatch occurs.

Problem

The debug log message uses Python implicit string concatenation across multiple lines, but the last line is a plain string (not an f-string) and is missing a separator:

bt.logging.debug(
    f"...github_id={github_id})"
    "Removing cached evaluation"  # Missing f-prefix and separator
)

This produces output like:

Cache miss for UID 5: ...github_id=123)Removing cached evaluation

Instead of:

Cache miss for UID 5: ...github_id=123). Removing cached evaluation

Fix

  • Add f-string prefix to the last line
  • Add period and space separator between the parenthesis and "Removing"

The log message in the cache miss branch uses Python implicit string
concatenation but the last line is missing the f-string prefix and a
separator. This causes the output to read:
  '...github_id=123)Removing cached evaluation'
instead of:
  '...github_id=123). Removing cached evaluation'

Add f-prefix and period+space separator.
@anderdc
Copy link
Collaborator

anderdc commented Feb 17, 2026

needs to target test branch

@njlazzar-su njlazzar-su changed the base branch from main to test February 17, 2026 17:04
@njlazzar-su
Copy link
Contributor Author

fixed

njlazzar-su and others added 3 commits February 17, 2026 13:41
'Removing cached evaluation' doesn't interpolate any values, so the f-string prefix is not needed
@anderdc anderdc merged commit dae676c into entrius:test Feb 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants