fix(issue-discovery): merge fallback open counts#1381
Open
MkDev11 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@anderdc can you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue-discovery fallback open counts when the secondary current/open-count fetch fails.
The fallback now starts from OPEN issues visible in the successful lookback payload, then overlays cached per-repo or single-repo top-level counts using the larger value. This keeps cached stale data useful without letting partial cache entries or cached/default zero values erase fresh open-issue evidence and bypass the open-issue spam multiplier.
Related Issues
N/A - no public issue filed for this follow-up.
Type of Change
Testing
Commands run:
./.venv/bin/pytest tests/validator/issue_discovery/test_scan.py -q -k 'open_count_fetch_error or OpenIssueSpamSourceIsMirror' ./.venv/bin/pytest tests/validator/issue_discovery/test_scan.py -q ./.venv/bin/ruff check gittensor/validator/issue_discovery/scan.py tests/validator/issue_discovery/test_scan.py ./.venv/bin/ruff format --check gittensor/validator/issue_discovery/scan.py tests/validator/issue_discovery/test_scan.py git diff --checkChecklist