fix(issue-discovery): make credibility a gate, not a per-issue multiplier#1378
Closed
plind-junior wants to merge 1 commit into
Closed
fix(issue-discovery): make credibility a gate, not a per-issue multiplier#1378plind-junior wants to merge 1 commit into
plind-junior wants to merge 1 commit into
Conversation
|
You already have 3 open PRs in this repo. The threshold is 3, so closing this one until a maintainer can triage your existing PRs. Please don't open any more — they'll be closed too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue-discovery credibility (
solved / (solved + closed)) is used twice:MIN_ISSUE_CREDIBILITY = 0.80you score zero (issue_discovery/scoring.py:81)scan.py:586→scan.py:593)So a discoverer who already cleared the 0.80 gate is taxed again by the same ratio on every issue — and because the ratio is flat, a few NOT_PLANNED/duplicate closures drop an active discoverer below 0.80 and zero them out. Same failure mode as #1340, but on the issue-discovery path #1340 doesn't cover.
Fix
Make credibility a gate only — exactly the OSS direction in #1340 / #1359:
Credibility is still computed, reported, and gates eligibility; it just no longer double-charges past the gate. Each issue is scored on its own multipliers (label, time decay, review quality).
Kept in-place (no shared OSS/issue helper — that was declined in #491). The flat-ratio smoothing is left as a follow-up to track whatever #1359 lands.
Tests
test_credibility_is_gate_only_not_a_per_issue_tax: an eligible discoverer at credibility 0.80 (4 valid-solved + 1 closed) keeps a neutral 1.0 multiplier and earns untaxed score.Full suite: 878 passed. pyright / ruff / vulture clean.