fix(review): pass codex skills natively instead of paraphrasing them#1655
Open
peyton-alt wants to merge 1 commit into
Open
fix(review): pass codex skills natively instead of paraphrasing them#1655peyton-alt wants to merge 1 commit into
peyton-alt wants to merge 1 commit into
Conversation
expandCodexBuiltinReview silently REPLACED a configured /review skill with a generic 28-word instruction before composing the prompt — the configured skill never ran. This is the codex sibling of the claude -p slash-expansion bug: in both cases the child executed something other than what the user configured. Rewrite slash-form skill invocations (the agent-portable form profiles are configured with) into codex's native $name form, which codex's skill system resolves against its installed-skill catalog and loads the matching SKILL.md. Non-slash entries (plain instruction text) pass verbatim; PromptOverride is untouched. Extracted from PR #1370 (codex review correctness), which is closed in favor of this narrower fix: its live-token tailing remains queued as a separate follow-up, its per-spawn reasoning_effort was dropped by product decision (entire does not alter how skills run), and its skilldiscovery refactor is superseded. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Entire-Checkpoint: 281a46a17694
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Codex reviewer skill execution so configured /review-style skills are no longer silently replaced with a generic paraphrase. Instead, slash-form skills are rewritten into Codex’s native $name prompt form so Codex resolves and runs the installed SKILL.md workflows as configured.
Changes:
- Replace the old
/review→ paraphrase expansion with slash-form →$namerewriting for Codex prompts. - Remove the hardcoded paraphrase constant and expansion helper.
- Update/add tests to assert
$review(and other$...skills) appear in the composed prompt, and thatPromptOverrideremains verbatim.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/entire/cli/agent/codex/reviewer.go | Rewrites configured slash skills into Codex-native $name invocations and removes the old paraphrase behavior. |
| cmd/entire/cli/agent/codex/reviewer_test.go | Updates expectations for $review and adds coverage for multi-skill rewriting and PromptOverride bypass. |
Comment on lines
33
to
+35
| // buildCodexReviewCmd builds the exec.Cmd for a codex review run. | ||
| // Exposed at package level for test inspection of argv, stdin, and env. | ||
| // buildCodexReviewCmd builds the exec.Cmd for a codex review run. |
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/776
Problem
expandCodexBuiltinReviewsilently replaced a configured/reviewskill with a generic 28-word instruction before composing the codex prompt — the configured skill never ran. This is the codex sibling of the claude-pslash-expansion bug fixed in #1647: in both cases the child executed something other than what the user configured.Change
Slash-form skill invocations (the agent-portable form profiles are configured with) are rewritten to codex's native
$nameform, which codex's skill system resolves against its installed-skill catalog and loads the matching SKILL.md. Non-slash entries (plain instruction text) pass verbatim;PromptOverrideis untouched. The paraphrase constant and expansion are deleted.With #1647 (claude Skill-tool invocation) and #1651 (skill fan-out), this completes faithful parallel skill execution for both agents: N configured skills → N parallel children, each natively running exactly its skill.
Relationship to #1370
Extracted from #1370 (codex review correctness), which this supersedes for merge purposes:
reasoning_effort→ dropped by product decision (entire invokes skills; it does not alter how they run)Testing
mise run test(7,558) green, lint clean🤖 Generated with Claude Code
Note
Low Risk
Localized change to codex review prompt assembly; fixes incorrect behavior without touching auth, data, or shared review core beyond skill string rewriting.
Overview
Codex review no longer substitutes configured slash skills with a generic paraphrase. Profile skills like
/revieware rewritten to codex’s native$nameform so codex loads the real SKILL.md; plain text lines stay unchanged.The old
expandCodexBuiltinReviewpath andcodexBuiltinReviewPromptare removed.codex exec -with the composed prompt on stdin is unchanged (still avoidscodex exec reviewlimitations).Tests now expect
$reviewin the prompt and add coverage for multi-skill$rewriting andPromptOverridebypassing skill transforms.Reviewed by Cursor Bugbot for commit 3c75670. Configure here.