docs(cryptify): document HTTP Range support on /filedownload#87
Open
dobby-coder[bot] wants to merge 1 commit into
Open
docs(cryptify): document HTTP Range support on /filedownload#87dobby-coder[bot] wants to merge 1 commit into
dobby-coder[bot] wants to merge 1 commit into
Conversation
Contributor
Author
There was a problem hiding this comment.
Self-review (cannot --approve own PR). Verified end-to-end:
- Source link
src/main.rs#L959-L1083atb1eff690eareturns 200; snippet matches the documented behavior:Accept-Ranges: byteson every response,parse_range_headersupportsbytes=N-M,bytes=N-, andbytes=-N(open-ended/suffix clamped to file size), multi-range returnsNoneso the caller emits416, unsatisfiable path setsContent-Range: bytes */total. npx vitepress build docssucceeds (~6.5s). Rendereddist/repos/cryptify.htmlanddist/guide/architecture.htmlboth contain therange-support-on-filedownloadanchor.- Style conforms: no banned words, no em dashes, no bold, no significance inflation.
- Architecture-page row stays one sentence and links into the cryptify subsection, consistent with the upload-limits / auth cross-references.
Ready to merge from this agent's perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #85
Summary
Documents the new Range / Accept-Ranges behaviour on cryptify's
GET /filedownload/{uuid}introduced by encryption4all/cryptify#154 (merged atb1eff690ea).docs/repos/cryptify.md: cross-links the existing API bullet to a new "Range support on /filedownload" subsection covering the four response shapes (200 full, 206 partial, 416 unsatisfiable/multi-range), notesRangejoining the CORS allowlist alongsideAuthorization,Content-Type,Content-Range,CryptifyToken, andX-Recovery-Token.docs/guide/architecture.md: extends the Cryptify endpoint-table row for/filedownload/{uuid}with a one-sentence summary and a link into the cryptify page subsection.Source link pinned to the cryptify merge commit (
b1eff690ea...src/main.rs#L959-L1083).Verification
npx vitepress build docssucceeds (~6s, mermaid still renders).docs/.vitepress/dist/repos/cryptify.htmlanddist/guide/architecture.html; new anchor#range-support-on-filedownloadresolves.Reviewer quickstart