docs(outlook-addon): default-off, fail-closed send, Settings view#77
Merged
Merged
Conversation
Reflects postguard-outlook-addon PRs #63 and #67. Old defaults (opt-out + optimistic displayDialogAsync) are gone; new model: - New "Encryption defaults and per-draft control" section covering pg.encryptionEnabled (mailbox-wide default off), the x-pg-encrypt-on-send header, the persistent compose banner, and the fail-closed/fail-open contract. - New "Settings view" section for the gear icon, pg.encryptionEnabled, pg.allowOptimisticDialog, and the sign-attribute prefills. - Architecture section mentions OnNewMessageCompose alongside OnMessageSend and the new settings.ts helper. - Per-platform behaviour table rewritten around the new prompt-by-default open path and the optimistic opt-in. - displayDialogAsync code excerpt replaced with the new optimistic-vs-prompt logic, pinned to current master HEAD. Closes #76
rubenhensen
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
docs/repos/postguard-outlook-addon.mdafter postguard-outlook-addon#67 and postguard-outlook-addon#63.pg.encryptionEnabledmailbox-wide setting,x-pg-encrypt-on-sendheader, persistent compose banner, fail-closed/fail-open contract viacommittedToEncrypt.OnNewMessageComposealongsideOnMessageSendandsrc/lib/settings.ts.promptBeforeOpen: truedefault and thepg.allowOptimisticDialogopt-in.displayDialogAsynccode excerpt replaced with the new optimistic-vs-prompt block, pinned to current master HEAD (2fcc56e).Closes #76.
Verification
npm run docs:build— passes (~5s).dist/repos/postguard-outlook-addon.htmlcontains all new identifiers:OnNewMessageCompose,x-pg-encrypt-on-send,pg.encryptionEnabled,pg.allowOptimisticDialog,committedToEncrypt, "Settings view".Reviewer quickstart
git fetch origin && git checkout update-outlook-addon-defaults-off-fail-closed && npm install && npm run docs:devThen open
/repos/postguard-outlook-addonin the preview and check the Encryption defaults and per-draft control, Settings view, and Per-platform behaviour sections.