website: use <div> instead of <p>#503
Open
abetomo wants to merge 1 commit into
Open
Conversation
The following warning will occur, so replace it with `<div>`. ``` $ npm run build ... [WARNING] Docusaurus static site generation process emitted warnings for 5 paths This is non-critical and can be disabled with DOCUSAURUS_IGNORE_SSG_WARNINGS=true Troubleshooting guide: facebook/docusaurus#10580 - "/1.0/": - [HTML minifier diagnostic - error] No "p" element in scope but a "p" end tag seen - {"primary_spans":[{"end":13960,"start":13956}],"span_labels":[]} - "/1.0/purchase/": - [HTML minifier diagnostic - error] No "p" element in scope but a "p" end tag seen - {"primary_spans":[{"end":19822,"start":19818}],"span_labels":[]} - [HTML minifier diagnostic - error] No "p" element in scope but a "p" end tag seen - {"primary_spans":[{"end":20215,"start":20211}],"span_labels":[]} - "/hardware/openarm-2.0/general": - [HTML minifier diagnostic - error] No "p" element in scope but a "p" end tag seen - {"primary_spans":[{"end":14289,"start":14285}],"span_labels":[]} - "/hardware/openarm-cell/general": - [HTML minifier diagnostic - error] No "p" element in scope but a "p" end tag seen - {"primary_spans":[{"end":14533,"start":14529}],"span_labels":[]} - "/purchase/": - [HTML minifier diagnostic - error] No "p" element in scope but a "p" end tag seen - {"primary_spans":[{"end":19472,"start":19468}],"span_labels":[]} - [HTML minifier diagnostic - error] No "p" element in scope but a "p" end tag seen - {"primary_spans":[{"end":19865,"start":19861}],"span_labels":[]} ... ``` The display is the same even when using `<div>`.
|
Preview: https://abetomo.github.io/openarm See https://github.com/enactic/openarm/blob/main/website/README.md#pull-request-and-preview how to configure preview on fork. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Docusaurus SSG/HTML-minifier warnings caused by invalid paragraph tag scope in several MDX pages by replacing problematic <p> wrappers with <div>.
Changes:
- Replaced
<p>with<div>in the purchase page “From the Manufacturer” section (both current docs and v1.0 docs). - Replaced a styled
<p>with<div>in the v1.0 getting-started landing page call-to-action blurb. - Replaced
<p>with<div>in hardware “3DCAD and BOM” callout blocks for OpenArm 2.0 and OpenArm Cell.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/versioned_docs/version-1.0/purchase/index.mdx | Removes paragraph tags in the manufacturer text block to avoid invalid </p> scope during minification. |
| website/versioned_docs/version-1.0/getting-started/index.mdx | Converts a styled paragraph CTA description to a div to prevent paragraph-scope HTML warnings. |
| website/docs/purchase/index.mdx | Mirrors the purchase-page tag change in current docs to eliminate the same minifier warning on /purchase/. |
| website/docs/hardware/openarm-cell/general.mdx | Converts a short paragraph block to div inside a callout to avoid paragraph-scope issues. |
| website/docs/hardware/openarm-2.0/general.mdx | Same as above for the OpenArm 2.0 hardware page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following warning will occur, so replace it with
<div>.The display is the same even when using
<div>.