Update tot version to be based on binary availability on all platforms - #1763
Open
sbc100 wants to merge 1 commit into
Open
Update tot version to be based on binary availability on all platforms#1763sbc100 wants to merge 1 commit into
tot version to be based on binary availability on all platforms#1763sbc100 wants to merge 1 commit into
Conversation
When resolving tip-of-tree (tot) release in get_emscripten_releases_tot, check that prebuilt binary archives exist for all standard TOT platforms (linux x86-64, mac x86-64, mac arm64, win x86-64) before selecting a revision. Previously, emsdk only checked binary availability for the host OS and architecture running emsdk. When emsdk-update CI ran on Linux, it could select a TOT revision before macOS or Windows binaries finished uploading. This has been causing issues in emscripten where the update-emsdk job (which updates test/emsdk_version.txt) was choosing a version that was available on linux, but not yet on all other platforms, causing the CI jobs to fail on some platforms (e.g. windows).
sbc100
commented
Aug 3, 2026
| make_url('tar.xz' if not WINDOWS else 'zip') | ||
| # that has uploaded binaries for all TOT platforms. | ||
| all_platforms = [ | ||
| ('linux', '', 'tar.xz'), |
Collaborator
Author
There was a problem hiding this comment.
I would include the linux-arm64 build here but currently we are only uploading those builds for LTO releases.
See https://chromium.googlesource.com/emscripten-releases/+/refs/heads/main/src/build.py#1132
Should we lift this restriction? @dschuff ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resolving tip-of-tree (tot) release in get_emscripten_releases_tot, check that prebuilt binary archives exist for all standard TOT platforms (linux x86-64, mac x86-64, mac arm64, win x86-64) before selecting a revision.
Previously, emsdk only checked binary availability for the host OS and architecture running emsdk. When emsdk-update CI ran on Linux, it could select a TOT revision before macOS or Windows binaries finished uploading.
This has been causing issues in emscripten where the update-emsdk job (which updates test/emsdk_version.txt) was choosing a version that was available on linux, but not yet on all other platforms, causing the CI jobs to fail on some platforms (e.g. windows).