Skip to content

[CI] Move x86 Windows launcher build job to GitHub Actions #27606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −28
Open

[CI] Move x86 Windows launcher build job to GitHub Actions #27606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,29 +1198,6 @@ jobs:
steps:
- test-sockets-chrome

build-windows-launcher:
executor:
name: win/server-2022
shell: bash.exe -eo pipefail
steps:
- checkout
- run:
name: "build pylauncher"
shell: cmd.exe
command: .circleci\setup_vs2022.bat && cd tools\pylauncher && call build.bat
- store_artifacts:
path: tools/pylauncher/pylauncher.exe
destination: pylauncher.exe
- install-emsdk
- pip-install:
python: "$EMSDK_PYTHON"
- run:
name: "create_entry_points"
command: $EMSDK_PYTHON tools/maint/create_entry_points.py --exe-files
- run:
name: "crossplatform tests"
command: test/runner.exe core0.test_hello_world

@kripken kripken Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a test here, but not in the new code - where is it?



# windows and mac do not have separate build and test jobs, as they only run
# a limited set of tests; it is simpler and faster to do it all in one job.
Expand Down Expand Up @@ -1403,7 +1380,6 @@ workflows:
- test-node-compat
- test-windows
- test-windows-browser-firefox
- build-windows-launcher
- test-mac-arm64:
requires:
- build-linux
Expand Down
4 changes: 0 additions & 4 deletions .circleci/setup_vs2022.bat
View file
Open in desktop

This file was deleted.

19 changes: 19 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,25 @@ jobs:
sudo update-alternatives --install /usr/bin/git-clang-format git-clang-format /usr/bin/git-clang-format-19 100
- run: tools/maint/clang-format-diff.sh origin/$GITHUB_BASE_REF

build-pylauncher-x64:
name: Build pylauncher (x64)
runs-on: windows-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- name: Setup MSVC
uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1.13.0
with:
arch: x64
- name: Build pylauncher
run: |
cd tools\pylauncher
call build.bat
shell: cmd
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: pylauncher.exe
path: tools/pylauncher/pylauncher.exe

build-pylauncher-arm64:
name: Build pylauncher (ARM64)
runs-on: windows-11-arm
Expand Down
Loading