Add fallback to wasm_bindgen. NFC#27311
Conversation
sbc100
left a comment
There was a problem hiding this comment.
I'd actually rather keep this local/isolated if possible rather than adding WASM_BINDGEN to shared.py, given there is only one user.
Is there some reason you cannot put wasm-bindgen in the $PATH?
|
I had hoped to avoid making this a configurable setting.. but maybe that isn't possible? |
|
Not really, I can certainly update my $PATH; I just thought this is the preferred way. Updated the PR to remove the configuration and additionally search for |
|
I would prefer maybe just depend on PATH in this case, rather than add another configuration point to maintain and test. |
|
Done! |
sbc100
left a comment
There was a problem hiding this comment.
Ah, is it sometimes called by different names? Maybe mention in the PR description why it could have two different names.
|
I'm not aware of a toolchain that builds |
This PR adds a fallback to
wasm_bindgenwhen looking forwasm-bindgenin $PATH