Skip to content

Add fallback to wasm_bindgen. NFC#27311

Open
stephenduong1004 wants to merge 2 commits into
emscripten-core:mainfrom
stephenduong1004:main
Open

Add fallback to wasm_bindgen. NFC#27311
stephenduong1004 wants to merge 2 commits into
emscripten-core:mainfrom
stephenduong1004:main

Conversation

@stephenduong1004

@stephenduong1004 stephenduong1004 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a fallback to wasm_bindgen when looking for wasm-bindgen in $PATH

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually rather keep this local/isolated if possible rather than adding WASM_BINDGEN to shared.py, given there is only one user.

Is there some reason you cannot put wasm-bindgen in the $PATH?

@sbc100

sbc100 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

I had hoped to avoid making this a configurable setting.. but maybe that isn't possible?

@sbc100 sbc100 changed the title Support WASM_BINDGEN_PATH [NFC] Support WASM_BINDGEN_PATH. NFC Jul 10, 2026
@stephenduong1004 stephenduong1004 changed the title Support WASM_BINDGEN_PATH. NFC Add fallback to wasm_bindgen. NFC Jul 10, 2026
@stephenduong1004

stephenduong1004 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Not really, I can certainly update my $PATH; I just thought this is the preferred way. Updated the PR to remove the configuration and additionally search for wasm_bindgen

@sbc100

sbc100 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

I would prefer maybe just depend on PATH in this case, rather than add another configuration point to maintain and test.

@stephenduong1004

Copy link
Copy Markdown
Collaborator Author

Done!

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, is it sometimes called by different names? Maybe mention in the PR description why it could have two different names.

@sbc100 sbc100 requested review from brendandahl and guybedford July 10, 2026 21:30
@guybedford

Copy link
Copy Markdown
Collaborator

I'm not aware of a toolchain that builds wasm_bindgen personally, it would be good to know what this applies to further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants