Skip to content

[emval] Gate val thread-affinity check on __EMSCRIPTEN_PTHREADS__ instead of _REENTRANT #27109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iakovgi wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −2
Open

[emval] Gate val thread-affinity check on __EMSCRIPTEN_PTHREADS__ instead of _REENTRANT #27109

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55a32fc
[emval] Gate val thread-affinity check on __EMSCRIPTEN_PTHREADS__ ins…
iakovgi Jun 12, 2026
2e9a21d
Merge branch 'main' into fix/val-thread-assertion-gate
iakovgi Jun 12, 2026
a55431e
Merge branch 'main' into fix/val-thread-assertion-gate
iakovgi Jun 13, 2026
c6d9ec9
Merge branch 'main' into fix/val-thread-assertion-gate
iakovgi Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions system/include/emscripten/val.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ class EMBIND_VISIBILITY_DEFAULT val {
}

EM_VAL as_handle() const {
#ifdef _REENTRANT
#ifdef __EMSCRIPTEN_PTHREADS__
assert(pthread_equal(thread, pthread_self()) && "val accessed from wrong thread");
#endif
return handle;
Expand Down Expand Up @@ -568,7 +568,7 @@ class EMBIND_VISIBILITY_DEFAULT val {
private:
// takes ownership, assumes handle already incref'd and lives on the same thread
explicit val(EM_VAL handle) :
#ifdef _REENTRANT
#ifdef __EMSCRIPTEN_PTHREADS__
thread(pthread_self()),
#endif
handle(handle) {}
Expand Down