Skip to content

Require node v26 for WASM_EXCEPTIONS feature #27105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −12
Open

Require node v26 for WASM_EXCEPTIONS feature #27105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,8 +1034,6 @@ jobs:
other.test_js_optimizer_verbose
other.test_min_node_version
other.test_node_emscripten_num_logical_cores
other.test_exceptions_stack_trace*
other.test_exceptions_rethrow_stack_trace*
core2.test_pthread_create
core2.test_i64_invoke_bigint
core2.test_sse2
Expand All @@ -1060,6 +1058,9 @@ jobs:
other.test_node_emscripten_num_logical_cores
other.test_js_base64_api
other.test_pthread_growth*
other.test_exceptions_stack_trace*
other.test_exceptions_rethrow_stack_trace*
core2.test_*exception*_wasm
core2.test_hello_world
core2.test_pthread_create
core2.test_i64_invoke_bigint
Expand Down
8 changes: 3 additions & 5 deletions test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,15 +585,14 @@ def require_wasm_legacy_eh(self):

def require_wasm_eh(self):
if 'EMTEST_SKIP_WASM_EH' in os.environ:
self.skipTest('test requires node v24 or d8 (and EMTEST_SKIP_WASM_EH is set)')
self.skipTest('test requires node v26 or d8 (and EMTEST_SKIP_WASM_EH is set)')
self.set_setting('WASM_LEGACY_EXCEPTIONS', 0)

if self.is_browser_test():
self.check_browser_feature('EMTEST_SKIP_WASM_EH', Feature.WASM_EXCEPTIONS, 'test requires Wasm EH')
return

if self.try_require_node_version(22):
self.node_args.append('--experimental-wasm-exnref')
if self.try_require_node_version(26):
return

deno = get_deno()
Expand All @@ -610,10 +609,9 @@ def require_wasm_eh(self):
if v8:
self.cflags.append('-sENVIRONMENT=shell')
self.require_engine(v8)
self.v8_args.append('--experimental-wasm-exnref')
return

self.fail('either d8, deno, bun or node v24 required to run wasm-eh tests. Use EMTEST_SKIP_WASM_EH to skip')
self.fail('either d8, deno, bun or node v26 required to run wasm-eh tests. Use EMTEST_SKIP_WASM_EH to skip')

def require_jspi(self):
if 'EMTEST_SKIP_JSPI' in os.environ:
Expand Down
6 changes: 1 addition & 5 deletions tools/feature_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,7 @@ class Feature(IntEnum):
'chrome': 137,
'firefox': 131,
'safari': 180400,
# Supported with flag --experimental-wasm-exnref (TODO: Change this to
# unflagged version of Node.js 260000 that ships Wasm EH enabled, after
# Emscripten unit testing has migrated to Node.js 26, and Emsdk ships
# Node.js 26)
'node': 220000,
'node': 260000,
},
# Growable SharedArrayBuffers improves memory growth feature in multithreaded
# builds by avoiding need to poll resizes to ArrayBuffer views in Workers.
Expand Down
Loading