Skip to content

Automatically enable GROWABLE_ARRAYBUFFERS when min browser versions allow#27097

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:auto_enable_settings
Jun 12, 2026
Merged

Automatically enable GROWABLE_ARRAYBUFFERS when min browser versions allow#27097
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:auto_enable_settings

Conversation

@sbc100

@sbc100 sbc100 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

See #27096 (comment)

Also, remove the experimental status, since this feature is now available in all browser and we hope
to feature-detect it soon and start using it even without this flag.

Fixes: #26099

@sbc100 sbc100 requested a review from kleisauke June 11, 2026 17:08
Comment thread tools/link.py Outdated
Comment thread tools/feature_matrix.py Outdated
@sbc100

sbc100 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased on top of #27103

@sbc100 sbc100 force-pushed the auto_enable_settings branch from 42db730 to de757b7 Compare June 11, 2026 21:08
@sbc100 sbc100 requested review from kleisauke and kripken June 11, 2026 21:09
@sbc100 sbc100 force-pushed the auto_enable_settings branch 2 times, most recently from 0fac509 to 7c02356 Compare June 11, 2026 22:21
Comment thread tools/link.py
@kleisauke

Copy link
Copy Markdown
Collaborator

wasm2js1.test_environment seems to fail on CI, but I'm not sure why. Perhaps emsdk needs to include Node.js 26 too?

@sbc100 sbc100 force-pushed the auto_enable_settings branch 2 times, most recently from 480a566 to 7233255 Compare June 12, 2026 16:34
@sbc100

sbc100 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

wasm2js1.test_environment seems to fail on CI, but I'm not sure why. Perhaps emsdk needs to include Node.js 26 too?

Turns out GROWABLE_ARRAYBUFFERS is not compatible with wasm2js, so I encoded that too.

@sbc100 sbc100 force-pushed the auto_enable_settings branch from 7233255 to a8045e9 Compare June 12, 2026 18:42
@sbc100 sbc100 enabled auto-merge (squash) June 12, 2026 18:46
@sbc100 sbc100 merged commit 99c29da into emscripten-core:main Jun 12, 2026
39 checks passed
@sbc100 sbc100 deleted the auto_enable_settings branch June 12, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wasmMemory.toResizableBuffer is not a function

3 participants