[ports] Initialize ICU source path early in get()#27019
Open
sbc100 wants to merge 1 commit into
Open
Conversation
Currently, icu_source_path is only initialized inside prepare_build(), which is deferred to the `create_libicu_common` creator. If `libicu_common` is already cached, but other ICU libraries (like `libicu_stubdata`) are missing from the cache, the common creator is skipped. This results in `prepare_build()` never being called, leaving icu_source_path as None and causing subsequent builders to crash with a TypeError in os.path.join. Fix this by initializing icu_source_path immediately at the top of get(), and removing the redundant prepare_build() logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, icu_source_path is only initialized inside prepare_build(), which is deferred to the
create_libicu_commoncreator.If
libicu_commonis already cached, but other ICU libraries (likelibicu_stubdata) are missing from the cache, the common creator is skipped. This results inprepare_build()never being called, leaving icu_source_path as None and causing subsequent builders to crash with a TypeError in os.path.join.Fix this by initializing icu_source_path immediately at the top of get(), and removing the redundant prepare_build() logic.