[pthreads] Simplify message relaying code#27018
Open
sbc100 wants to merge 1 commit into
Open
Conversation
Historically, `targetThread` relaying was used to pass `objectTransfer` messages (containing `OffscreenCanvas` objects) back to parent threads on worker exit. This was introduced in commit 1b27891 (2018/2019) and required supporting `transferList` in the relaying code. However, automatic canvas return on exit was later disabled in 6dcf729 (2019) and the `objectTransfer` command was fully removed in 0f536c6 (2021). These days, the relaying mechanism is only used by `CMD_CHECK_MAILBOX` (via `_emscripten_notify_mailbox_postmessage`) to send simple mailbox notifications, which do not require a transfer list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historically,
targetThreadrelaying was used to passobjectTransfermessages (containingOffscreenCanvasobjects) back to parent threads on worker exit. This was introduced in commit 1b27891 (2018/2019) and required supportingtransferListin the relaying code.However, automatic canvas return on exit was later disabled in 6dcf729 (2019) and the
objectTransfercommand was fully removed in 0f536c6 (2021).These days, the relaying mechanism is only used by
CMD_CHECK_MAILBOX(via_emscripten_notify_mailbox_postmessage) to send simple mailbox notifications, which do not require a transfer list.