Skip to content

[WasmFS] Ensure error codes are positive in _wasmfs_node_* APIs #26616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kleisauke merged 3 commits into from
Apr 4, 2026
Merged

[WasmFS] Ensure error codes are positive in _wasmfs_node_* APIs #26616

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75f250b
[WasmFS] Ensure error codes are positive in `_wasmfs_node_*` APIs
kleisauke Apr 3, 2026
8df6119
Merge branch 'main' into wasmfs-ensure-positive-error-codes
kleisauke Apr 4, 2026
571f095
Merge branch 'main' into wasmfs-ensure-positive-error-codes
kleisauke Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/libwasmfs_node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,14 @@ addToLibrary({
_wasmfs_node_truncate__i53abi: true,
_wasmfs_node_truncate__deps : ['$wasmfsTry'],
_wasmfs_node_truncate : (path_p, len) => {
if (isNaN(len)) return -{{{ cDefs.EOVERFLOW }}};
if (isNaN(len)) return {{{ cDefs.EOVERFLOW }}};
return wasmfsTry(() => fs.truncateSync(UTF8ToString(path_p), len));
},

_wasmfs_node_ftruncate__i53abi: true,
_wasmfs_node_ftruncate__deps : ['$wasmfsTry'],
_wasmfs_node_ftruncate : (fd, len) => {
if (isNaN(len)) return -{{{ cDefs.EOVERFLOW }}};
if (isNaN(len)) return {{{ cDefs.EOVERFLOW }}};
return wasmfsTry(() => fs.ftruncateSync(fd, len));
},

Expand Down
4 changes: 2 additions & 2 deletions system/lib/wasmfs/backends/node_backend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ class NodeFile : public DataFile {

int setSize(off_t size) override {
if (state.isOpen()) {
return _wasmfs_node_ftruncate(state.getFD(), size);
return -_wasmfs_node_ftruncate(state.getFD(), size);
}
return _wasmfs_node_truncate(state.path.c_str(), size);
return -_wasmfs_node_truncate(state.path.c_str(), size);
}

int open(oflags_t flags) override { return state.open(flags); }
Expand Down
Loading