Make source map names field optional #26108
Closed
+60
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes 'names' field generation in source maps optional, turned off by default. This may be necessary if the source map size is often prohibitively large as in emscripten-core#26100, which I'm not sure is the common case yet.
sbc100
approved these changes
Jan 14, 2026
src/settings_internal.js
Outdated
| // -gsource-map=inline | ||
| var EMBED_SOURCE_MAP_SOURCE = 0; | ||
| // -gsource-map=names | ||
| var GENERATE_SOURCE_MAP_NAMES = 0; |
Collaborator
There was a problem hiding this comment.
I wonder if it would make sense to have SOURCE_MAP_ at the start of all these internal setting names?
Member
Author
There was a problem hiding this comment.
Changed from -> to
GENERATE_SOURCE_MAP -> SOURCE_MAP_GENERATE
EMBED_SOURCE_MAP_SOURCE -> SOURCE_MAP_EMBED_SOURCE
GENERATE_SOURCE_MAP_NAMES -> SOURCE_MAP_GENERATE_NAMES
GENERATE_SOURCE_MAP -> SOURCE_MAP_GENERATE EMBED_SOURCE_MAP_SOURCE -> SOURCE_MAP_EMBED_SOURCE GENERATE_SOURCE_MAP_NAMES -> SOURCE_MAP_GENERATE_NAMES
Member
Author
|
Closing in favor of #26149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes 'names' field generation in source maps optional, turned off by default. This may be necessary if the source map size is often prohibitively large as in #26100, which I'm not sure is the common case yet.