Open
Conversation
A team admin has role admin on all roles under that team, which will hopefully make setting up things like the stage roles a bit less arduous.
- Users with admin for roles in many teams see roles grouped by team. - Users with admin for mulitple roles in the same team see no change. - Users with admin for one role get redirect straight to the relevant page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ballooned somewhat, so apologies for the messy commit history. I did what I could with rebasing to make it at least more coherent than the process that got me here.
The idea here is to nest all volunteer roles under a team, which allows a few things:
I've also moved most of the volunteer related associations (role admin in particular) to the Volunteer model where they're closer to where they'll be used. We might want to reconsider Volunteer existing at all in the future but while it does lets use it.