apps/schedule/frab_exporter: re-add event slug to frab slug

[Kunsi]

Seems like this got lost in a1a8af4

[marksteward]

I left that off because we generate slugs with non-ascii characters in, such as blåhaj.

If we want to add them back, we should work out how to make python-slugify generate ascii-only slugs just for frab.

[Kunsi]

Would you object to just implement slugification ourselves? I recently(tm) re-did slugs for pretalx as well: https://github.com/pretalx/pretalx/blob/main/src/pretalx/schedule/models/slot.py#L218-L226

(Alternatively we could adjust the schema to include non-ascii characters, i can discuss that with the schema maintainers)

[Kunsi]

Would you object to just implement slugification ourselves?

I implemented that in the exporter. We can always move this to somewhere else and use it everywhere at a later point in time.

[marksteward]

Sure, though it might be as simple as having schedule_item_slug accept allow_unicode.

python-slugify already has a matching regex, and uses unidecode so CJK, Arabic and Hindi characters aren't discarded. From a quick check, the only difference when passing allow_unicode=False vs True is in how apostrophes and £ are treated.

Ultimately I'd prefer to have unicode slugs, but I don't want us to be the cause of breaking pipelines.

[Kunsi]

I'll take a look at it later today or tomorrow. I don't know of anything that would break if we had non-ascii characters in the slug (well, apart from the schema validation atleast).

[Kunsi]

you were right, that's much easier. i also rebased onto current main and tested that everything works correctly.