Skip to content

Comments

Use native API for domain lookup#4

Open
dkniffin wants to merge 1 commit intoemerysteele:masterfrom
dkniffin:fix-domain-lookup
Open

Use native API for domain lookup#4
dkniffin wants to merge 1 commit intoemerysteele:masterfrom
dkniffin:fix-domain-lookup

Conversation

@dkniffin
Copy link

@dkniffin dkniffin commented Mar 25, 2022

This fixes an issue where localhost (or localhost:3000) is not looked up properly, and so there'd be a separate profile for each page of the site.

@dkniffin
Copy link
Author

It looks like there's another issue somewhere though, because the cookie is not being updated appropriately when I switch between profiles

@dkniffin
Copy link
Author

Finally got around to looking at this again! It looks like I needed .hostname, not .host, because .host includes the port, and cookie domains don't include the port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant