Pull router_js into the Ember monorepo#21211
Conversation
bump dependencies
When calling replace on a replace, it should replace not update
The versions of prettier should be updated manually (to avoid churn in unrelated PRs).
Prevent context matching if the oldContext is null
fix `{{url-for 'posts' (hash queryParams=paramsHash)}}` use case
Fix a crash when (hash) helper is used to create queryParams object
Move to TypeScript
make delegate optional
[BREAKING] Router Abstract Base class
Expose HandlerInfo type
|
The Browserstack errors are consistent |
This is very strange 🙈 the CI run just before I removed an eslint commit passed without any issue: https://github.com/emberjs/ember.js/actions/runs/23306124516 so something strange/flakey is going on here And the errors have nothing to do with the router https://github.com/emberjs/ember.js/actions/runs/23309427423/job/67814938742#step:6:128 the last two runs failed on It could be that integrating the router_js test suite has introduced new flakiness but there is 0% chance that there was a causal reason why this is failing (and only on safari too 🫠 ) |
|
@kategengler @NullVoxPopuli I ended up removing the custom backburner wrapper in the tests since the flakeyness was probably being caused by that leaking (somehow) To review that last commit you should probably ignore whitespace 🙈 the change is much smaller when you do because of indentation changes and prettier 🫠 |
NullVoxPopuli
left a comment
There was a problem hiding this comment.
test changes seem reasonable!
With the Router RFC coming very soon we need to have router_js in the main monorepo. This PR does that work (with preserving history)
Still todo:
For anyone wanting to review this PR and not wanting to read all history from all of router_js then you can start at this commit and use the "Next commit" links at the top to go forward
Alternatively you can see the full diff with actual changes by looking at this link: mansona/ember.js@60942e2...mansona:ember.js:router-js