Normalize to always import from 'backburner.js'#20328
Closed
chriskrycho wants to merge 1 commit intomainfrom
Closed
Normalize to always import from 'backburner.js'#20328chriskrycho wants to merge 1 commit intomainfrom
'backburner.js'#20328chriskrycho wants to merge 1 commit intomainfrom
Conversation
We had a mix of different import locations for this, both the ES imports via `backburner.js` and the Ember CLI-munged version available at `backburner`. Switch to only using the Node-resolveable version, so TS can resolve it correctly; and enforce it by removing `backburner` from the list of `core` modules in the ESLint config.
chriskrycho
force-pushed
the
backburner-import
branch
from
91999d3 to
40a0332
Compare
Contributor
Author
|
This is blocked on figuring out what part of the build pipeline makes |
Contributor
Author
|
Fixed along the way to #20449, and I just forgot to close it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a mix of different import locations for this, both the ES imports via
backburner.jsand the Ember CLI-munged version available atbackburner. Switch to only using the Node-resolveable version, so TS can resolve it correctly; and enforce it by removingbackburnerfrom the list ofcoremodules in the ESLint config.