Fork Worker only if Cluster Initialized#111
Open
snewcomer wants to merge 4 commits intoember-fastboot:masterfrom
Open
Fork Worker only if Cluster Initialized#111snewcomer wants to merge 4 commits intoember-fastboot:masterfrom
snewcomer wants to merge 4 commits intoember-fastboot:masterfrom
Conversation
snewcomer
changed the title
rwjblue
requested changes
Oct 26, 2020
| // fail hard if first boot fails | ||
| forkWorkersPromise.catch((error) => { | ||
| this.ui.writeLine(error); | ||
| process.exit(1); |
Member
There was a problem hiding this comment.
Hmm, I don't really like the usage of process.exit here 🤔
Comment on lines
+177
to
+182
| let firstBootResolve; | ||
| let firstBootReject; | ||
| const firstBootPromise = new Promise((resolve, reject) => { | ||
| firstBootResolve = resolve; | ||
| firstBootReject = reject; | ||
| }); |
Member
There was a problem hiding this comment.
This seems a bit odd, can you refactor to not capture the resolve/reject and instead move the worker.on code inside the promise callback?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #112
close #112