Add template-no-let-reference rule to recommended-gjs and recommended-gts configs #1981
Add template-no-let-reference rule to recommended-gjs and recommended-gts configs #1981NullVoxPopuli merged 1 commit intoember-cli:masterfrom
template-no-let-reference rule to recommended-gjs and recommended-gts configs #1981Conversation
|
🎉 |
| description: 'disallow referencing let variables in \\<template\\>', | ||
| category: 'Ember Octane', | ||
| recommended: true, | ||
| recommended_for: 'gjs', |
There was a problem hiding this comment.
Can we follow the current pattern which is configName: true to indicate if the rule belongs to a config?
There was a problem hiding this comment.
You mean replace recommended_for with configName: 'gts'?
There was a problem hiding this comment.
Any examples for that property?
There was a problem hiding this comment.
No, we should use the config name as the property name, no shorthand:
recommendedGts: true
And then we can automatically transform camelCase to kebab-case when checking if a rule is enabled for a config.
patricklx
force-pushed
the
patch-6
branch
2 times, most recently
from
89f089b to
57a1e24
Compare
bmish
left a comment
bmish
left a comment
There was a problem hiding this comment.
Thanks.
In the future, please use a more descriptive PR title and description. The PR title will end up displayed publicly in the changelog and needs to provide appropriate context. The PR description should provide additional context.
bmish
changed the title
template-no-let-reference rule to recommended-gjs and recommended-gts configs
3 participants
And remove from
recommendedconfig.Follow-up to:
recommendedrule:template-no-let-reference#1977