Merged
Conversation
patricklx
force-pushed
the
template-indent-rule
branch
2 times, most recently
from
45b1e2a to
81fd18f
Compare
Closed
patricklx
force-pushed
the
template-indent-rule
branch
from
81fd18f to
95aac10
Compare
patricklx
force-pushed
the
template-indent-rule
branch
2 times, most recently
from
45a2363 to
92bf323
Compare
NullVoxPopuli
approved these changes
Nov 2, 2023
patricklx
force-pushed
the
template-indent-rule
branch
2 times, most recently
from
d042605 to
f69523b
Compare
patricklx
force-pushed
the
template-indent-rule
branch
from
f69523b to
c0cdaa7
Compare
bmish
reviewed
Nov 2, 2023
bmish
reviewed
Nov 2, 2023
lib/rules/template-indent.js
Outdated
| type: 'layout', | ||
| docs: { | ||
| description: 'enforce consistent indentation', | ||
| extendsBaseRule: true, |
Member
There was a problem hiding this comment.
Let's not export non-standard properties. I have not seen extendsBaseRule before.
bmish
reviewed
Nov 2, 2023
lib/rules/template-indent.js
Outdated
| meta: { | ||
| type: 'layout', | ||
| docs: { | ||
| description: 'enforce consistent indentation', |
Member
There was a problem hiding this comment.
Let's get a better description. Indentation for what?
patricklx
force-pushed
the
template-indent-rule
branch
from
c0cdaa7 to
0170dc8
Compare
patricklx
force-pushed
the
template-indent-rule
branch
from
0170dc8 to
e63a1cb
Compare
bmish
reviewed
Nov 2, 2023
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
bmish
reviewed
Nov 2, 2023
bmish
reviewed
Nov 2, 2023
bmish
reviewed
Nov 2, 2023
docs/rules/template-indent.md
Outdated
Comment on lines
22
to
24
| ## Rule Details | ||
|
|
||
| Enforce consistent indentation for fcct templates |
Member
There was a problem hiding this comment.
Can you combine this Rule Details section with the summary on lines 7-9? And use complete sentences and put the rule details/summary above the config section.
bmish
reviewed
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses the base eslint indent rule to make indents for templates.
similar implementation like typescript/indent https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/indent.ts
depends on #1942