Allow forcing localhost when not using Ember-CLI to serve project#22
Open
davidgovea wants to merge 3 commits intoember-cli:masterfrom
Open
Allow forcing localhost when not using Ember-CLI to serve project#22davidgovea wants to merge 3 commits intoember-cli:masterfrom
davidgovea wants to merge 3 commits intoember-cli:masterfrom
Conversation
|
I think this is fixed for you in the current version. https://github.com/rwjblue/ember-cli-inject-live-reload/blob/master/index.js#L19 . Now it automatically uses the current hostname. |
Author
|
Hey @jrobeson - that's actually the problem in my case. During development, our application is served from a non-standard host/IP through apache, and our environment does not allow for ember-cli to bind to that host. I want to serve the application from some weird IP, but serve the livereload script from ember-cli on localhost. The people in issue #13 seem do have similar needs. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #13 -
We don't use ember-cli to serve our dist/ directory. We also use a non-standard local hostname.
This change adds a
liveReloadForceLocalhostoption to force the addon to expect the livereload script on a fully-qualified localhost URL (rather than a relative path).Ember-CLI's
baseURLandportoptions are respected.It could be further generalized to be more customizable, but my assumption is that CLI will really only be used on localhost. Since there's already a semi-hardcode (
location.hostname || 'localhost'), this seems reasonable to me.To use,
Seems to be working for us - let me know what you think!
Thanks,
-david