fix: rolling update current leader handling - #441
Merged
Conversation
thweetkomputer
marked this pull request as ready for review
July 29, 2026 02:22
zhangh43
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
eloqctl update --current-master-nodesoption; rolling update now discovers current topology fromCLUSTER NODES.master_id, and voter nodes instead of treating all non-replicas as masters.--skip-log-restartsupport so standalone log service restart can be skipped during update.Why
The previous rolling update path depended on configuration order or a manually supplied current master list. That is unsafe when the actual master differs from the configured master, and it does not handle voter restart sequencing clearly.
The new flow uses live
CLUSTER NODESstate, keeps a temporary standby leader alive while the other nodes are upgraded, and only restarts that temporary leader at the end.Validation
cargo check -p cluster_mgrcargo build --release -p cluster_mgr --bin eloqctlcargo test -p cluster_mgr topology_task_uses_standby_startup_node_when_master_is_down