Skip to content

fix: consume fuel for parsing anon functions #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rma97 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: consume fuel for parsing anon functions #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/spitfire.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,6 +2133,8 @@ defmodule Spitfire do
{exprs, parser} =
with_context(parser, %{stop_before_stab_op?: true}, fn parser ->
while2 current_token(parser) not in [:end, :eof] <- parser do
parser = consume_fuel(parser)

{ast, parser} =
case Map.get(parser, :stab_state) do
%{ast: lhs} ->
Expand Down
7 changes: 7 additions & 0 deletions test/spitfire_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2356,6 +2356,13 @@ defmodule SpitfireTest do
assert {:error, _ast, _errors} = Spitfire.parse("fn ->\n)")
end

test "fn -> followed by block identifier exhausts fuel instead of hanging" do
assert Spitfire.parse("fn -> catch") == {:error, :no_fuel_remaining}
assert Spitfire.parse("fn -> after") == {:error, :no_fuel_remaining}
assert Spitfire.parse("fn -> rescue") == {:error, :no_fuel_remaining}
assert Spitfire.parse("fn -> else") == {:error, :no_fuel_remaining}
end

test "missing bitstring brackets" do
code = """
<<one::
Expand Down
Loading