Skip to content

fix: prevent infinite loop when typing out anonymous function #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhanberg merged 2 commits into from
Mar 4, 2026
Merged

fix: prevent infinite loop when typing out anonymous function #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
612e6ac
fix: prevent infinite loop when typing out anonymous function
katafrakt Mar 4, 2026
c375e70
Update spitfire_test.exs
mhanberg Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/spitfire.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2180,7 +2180,7 @@ defmodule Spitfire do

{ast, parser} =
cond do
current_token(parser) == :-> and peek_token(parser) == :end ->
current_token(parser) == :-> and peek_token(parser) in [:")", :end, :eof] ->
parser = next_token(parser)
{ast, parser}

Expand Down
8 changes: 8 additions & 0 deletions test/spitfire_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2348,6 +2348,14 @@ defmodule SpitfireTest do
end)
end

# https://github.com/elixir-lang/expert/issues/461
test "fn -> followed by closing delimiter does not hang" do
assert {:error, _ast, _errors} = Spitfire.parse("fn ->)")
assert {:error, _ast, _errors} = Spitfire.parse("fn ->")
assert {:error, _ast, _errors} = Spitfire.parse("Enum.map(fn ->)")
assert {:error, _ast, _errors} = Spitfire.parse("fn ->\n)")
end

test "missing bitstring brackets" do
code = """
<<one::
Expand Down