Remove duplicated prepare#352
Merged
warmwaffles merged 2 commits intoJul 14, 2026
Merged
Conversation
It looks like a remnant from a time when adding query caching was attempted, but later was abandoned.
Member
|
I wouldn't say it coming back is impossible. I just tossed it at the time because I envisioned access patterns where the queries would vary in composition. |
warmwaffles
approved these changes
Jul 14, 2026
warmwaffles
left a comment
warmwaffles
left a comment
Member
There was a problem hiding this comment.
This looks reasonable.
Curious, how did you find the incorrect typespecs?
Contributor
Author
|
I'm afraid there's no secret sauce to it, I just tend to sometimes spot such things. I don't claim everything is correct now. |
Member
|
Well I appreciate it. I usually can spot those as well, but sometimes callbacks like this slip through because the typespec is terse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started reading
connection.exto understand query caching story (before reading in the readme that it's not supported; hours of reading the code can save minutes of reading the docs). During that I noticed that there isprepareandprepare_no_cachethat are basically identical and definitely both are not caching. I figures this is some leftover from adding the cache in the past. From #41 I understand it's not coming back, so perhaps it's ok to clean this up.Also fixes some typespecs that are not in line with the implementation.