Fixes crash when path is too long

[aaronrenner]

Currently when making a request with a path that's too long fails with the following error:

13:10:46.870 [error] Handler :plug_cowboy has failed and has been detached. Class=:error
Reason={:badkey, :method,
 %{peer: {{127, 0, 0, 1}, 61468}, ref: Plug.Cowboy.ConnTest.HTTP}}
Stacktrace=[
  {Plug.Cowboy, :handle_event, 4, [file: ~c"lib/plug/cowboy.ex", line: 486]},
  {:telemetry, :"-execute/3-fun-0-", 4,
   [
     file: ~c"/Users/arenner/projects/plug_cowboy/deps/telemetry/src/telemetry.erl",
     line: 160
   ]},
  {:lists, :foreach_1, 2, [file: ~c"lists.erl", line: 1686]},
  {:cowboy_metrics_h, :early_error, 5,
   [
     file: ~c"/Users/arenner/projects/plug_cowboy/deps/cowboy/src/cowboy_metrics_h.erl",
     line: 325
   ]},
  {:cowboy_http, :early_error, 5,
   [
     file: ~c"/Users/arenner/projects/plug_cowboy/deps/cowboy/src/cowboy_http.erl",
     line: 1490
   ]},
  {:cowboy_http, :error_terminate, 3,
   [
     file: ~c"/Users/arenner/projects/plug_cowboy/deps/cowboy/src/cowboy_http.erl",
     line: 1480
   ]},
  {:cowboy_http, :parse, 2,
   [
     file: ~c"/Users/arenner/projects/plug_cowboy/deps/cowboy/src/cowboy_http.erl",
     line: 356
   ]},
  {:proc_lib, :init_p_do_apply, 3, [file: ~c"proc_lib.erl", line: 241]}

This fixes that issue.

[josevalim]

Can you please look into the CI failures? ALso make sure to run mix format after. Thanks!

[aaronrenner]

Sorry, about forgetting to run the formatter. I cleaned up the stray variable. This test failure is already occurring on master

  1) test drainer drains connections correctly (Plug.Cowboy.DrainerTest)
     test/plug/cowboy/drainer_test.exs:24
     ** (EXIT from #PID<0.546.0>) exited in: :gen_server.call(#PID<0.552.0>, :which_children, :infinity)
         ** (EXIT) shutdown

[josevalim]

💚 💙 💜 💛 ❤️