fix: hang at startup if .bashrc contains exec call#527
fix: hang at startup if .bashrc contains exec call#527spicychickensauce wants to merge 3 commits intoelixir-lang:mainfrom
Conversation
|
I fixed the credo warning by extracting the args construction into its own function, should be good now |
|
I think interactive flag might be necessary to support mise in "path mode", which relies on the prompt display to activate. I also wonder if this is the best solution to the problem. Maybe instead there should be a flag passed to expert command, such as |
|
I'm also using mise, and it works for me only without the -i flag... I don't like if users need to configure the right behavior, then it will just not work out of the box for some and the setting will be hard to track down. Also, a timeout is needed anyway, as without it the whole lsp just hangs, with no logs to even help identify the problem. |
I agree with that. But what bothers me is what happens after - removal of
This is interesting. Maybe I misunderstood how the "path mode" works. How do you set up mise (for bash or for fish)? Can you paste first 4 lines of
Calling scripts in an interactive shell is also a correct behaviour. Relying on Maybe we need |
It will just run into a timeout in the worst case and fallback to the I think removing the
I set up mise in both bash and fish via
Yes, my |
See: #340
In my .bashrc I've got this at the end:
This is one of the recommended ways on how to set up fish on the arch wiki.
But, with this .bashrc, expert hangs indefinitely at startup.
The problem with the original code is the use of the
-iflag.I don't know the original intent behind using that flag here, so instead of simply removing it, I added a timeout + fallback without -i instead.