fix: build a single engine for multiple projects using the same toolchain versions#509
Draft
fix: build a single engine for multiple projects using the same toolchain versions#509
Conversation
46c2f06 to
bd7a165
Compare
toolchain versions
bd7a165 to
204b219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #466
When resuming a session on Expert itself, I would regularly see issues due to multiple engine builders trying to modify the same files. This PR introduces a coordinator that keeps track of finished and in-flight builds, and ensures that:
Besides fixing that issue, it also cuts down startup time for Expert by a lot, since we builds the engine once instead of thrice(forge, engine, expert), once one engine finishes building the rest are instant.