Thread full descr through fun_denormalize reduce#15524
Merged
josevalim merged 2 commits intoJun 24, 2026
Merged
Conversation
Previously inner representation was threaded and returned, which broke expectations of caller `non_term_type_to_quoted` Fixes elixir-lang#15523
lukaszsamson
commented
Jun 24, 2026
| # (a) must not raise when denormalization fails for an arity | ||
| assert opt_difference(fun([term()], atom()), fun([integer()], dynamic(atom()))) | ||
| |> to_quoted_string() == | ||
| "dynamic((term() -> atom()) and (integer() -> atom()))" |
Contributor
Author
There was a problem hiding this comment.
Note the rendered type is not precise here. The type is purely dynamic with upper bound (term() -> atom()) \ (integer() -> none()) and empty static part. The pretty printer drops arrow negations which, if I understand it, is by design
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously inner representation was threaded and returned, which broke expectations of caller
non_term_type_to_quotedFixes #15523Assisted-by: Claude Opus 4.8 & GPT 5.5