Conversation
Reviewer's Guide by SourceryThis pull request upgrades the gunicorn package in the requirements.txt file to version 22 or higher to address a security vulnerability. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.
36c63b4 to
7f05e73
Compare
|
I will give it a go to try to fix it. But indeed it looks like the errors will not be easy to fix. I will focus on the docker-compose error because this comes after github changed something on their end. |
601ec89 to
af0ea90
Compare
|
I tried, but I did not manage to make the CI pass, as expected. But I think that now the errors are real issues with the app. Feel free to close this. What do you think @uniqueg and the rest? |
|
@lvarin: The Docker Compose issue is probably due to Compose being bundled with Docker CE versions for years now, accessible via We will figure it out soon, as we need to keep on working on proTES anyway. |
|
Docker compose with or without But the CI issues need to be fixed independently of this security vulnerability update. The code errors seems to be related with |
|
The CI works! |
|
@uniqueg Can you check? |
|
@uniqueg if you have no time for this. Someone in CSC could merge it |
uniqueg
left a comment
There was a problem hiding this comment.
LGTM, just one nitpicking issue
|
I applied the change, so I will merge it. Let me know if you wanted another change |
Change applied, confirmed by third party
* Upgrade due to sec vul * Now we need to install docker-compose (before it was provided) * Disable 2 pylint warnings * Set the max line width to a 21st century number * Add wait for port * Remove the hyphen and replace it by a space * Fix the pymongo version so it does not fail * Fix the pymongo version so it does not fail * Fix the mypy version * Fix mypy (model.py) warnings * Disable E501 error
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
Please provide enough information so that others can review your pull request. Give a brief summary of the motivation. Refer to the corresponding issue/s with
#XXXXfor more information.Testing
Write the appropriate unit and integration tests, if applicable. Make sure these and all other tests pass.
Documentation
Please document your changes and test cases in the appropriate places, if applicable.
Style
Make sure your changes adhere to the coding/documentation style used throughout the project.
Closing issues
If your changes fix any issue/s, put
closes #XXXXin your comment to auto-close it/them.Credit
Add your credentials to the list of contributors once your pull request was merged.
Summary by Sourcery
Build: