Conversation
Reviewer's Guide by SourceryThis pull request migrates the project from No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Author
|
@sourcery-ai summary |
There was a problem hiding this comment.
Hey @JaeAeich - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
poetryto manage dependencies instead ofrequirements.txtandsetup.py. - Consider using
blackorruff formatto automatically format the code.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
JaeAeich
commented
Feb 21, 2025
Comment on lines
+102
to
+113
| # [tool.ruff.lint] | ||
| # select = [ | ||
| # "B", # flake8-bugbear | ||
| # "C90", # mccabe | ||
| # "D", # pydocstyle | ||
| # "E", # pycodestyle | ||
| # "F", # Pyflakes | ||
| # "I", # isort | ||
| # "PL", # pylint | ||
| # "SIM", # flake8-simplify | ||
| # "UP", # pyupgrade | ||
| # ] |
Author
There was a problem hiding this comment.
Note the huge fle changes when I have commented all the extra rules that we use or try to make standard.
Author
There was a problem hiding this comment.
Also yes most changes currently are quotation change, but even if I disable the quatation change rule, we would still have similar number of file changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #237
Fixes #238
Fixes #239
Summary by Sourcery
Chores: