feat: add With methods to customize CoreAttribute characteristics#195
Merged
feat: add With methods to customize CoreAttribute characteristics#195
Conversation
Allow users to customize type-independent characteristics of pre-built schema attributes without rebuilding them from scratch. This enables use cases like making "emails" required in CoreUserSchema while reusing the existing attribute definition. Added methods: WithDescription, WithMutability, WithRequired, WithReturned. All return a copy, leaving the original unmodified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to customize type-independent characteristics of pre-built schema attributes without rebuilding them from scratch. This enables use cases like making "emails" required in CoreUserSchema while reusing the existing attribute definition.
RFC 7643 Section 2.2 defines required as a per-attribute characteristic, and the
/Schemasendpoint is meant to reflect the actual schema a service provider supports. The spec does not prohibit making additional attributes required beyond the defaults defined in Section 4.Added methods:
WithDescription,WithMutability,WithRequired,WithReturned. All return a copy, leaving the original unmodified.Closes #176