Fix pdb / breakpoint() hang in workflow code (#1104)#2
Closed
elidlocke wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closing to force base-SHA recompute after syncing fork's main |
93c2129 to
eea3c60
Compare
When debug_mode=True (or TEMPORAL_DEBUG=1), breakpoint() inside workflow code now opens an interactive pdb prompt -- including from a sandboxed workflow run under pytest. Four pieces: - Inline dispatch on the asyncio main thread (via loop.call_soon to avoid nesting inside the dispatch task's __step() and tripping Python 3.14's task-entry validation). - breakpoint removed from the sandbox's invalid builtins so the call reaches the worker hook. Nothing else is relaxed. - A Pdb subclass that lands at the workflow's own frame, suspends sandbox checks during each REPL interaction, and overrides q/Ctrl-D to continue the workflow instead of failing it with BdbQuit. - A defensive sys.breakpointhook that raises a clear RuntimeError when breakpoint() is called from a workflow worker thread without debug_mode, replacing the previous silent hang. When debug_mode is not set, the worker's dispatch and sandbox config are unchanged. Adds a README subsection on debugging workflows and five tests at tests/worker/test_breakpoint_hang.py. Verified on Python 3.13 and 3.14. Closes temporalio#1104.
Owner
Author
|
Superseded by upstream temporalio#1568. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
When
debug_mode=Trueon the Worker (orTEMPORAL_DEBUG=1),breakpoint()inside workflow code now opens an interactive pdb prompt — including from a sandboxed workflow run underpytest. Four pieces:loop.call_soonto avoid nesting inside the dispatch task's__step()), so pdb'sinput()reaches the TTY.breakpointis removed from the sandbox's invalid builtins so the call can reach the worker hook. Nothing else is relaxed.q/ Ctrl-D to continue the workflow instead of failing it withBdbQuit.sys.breakpointhook. Callingbreakpoint()from a workflow worker thread withoutdebug_moderaises a clearRuntimeErrorinstead of silently hanging.When
debug_modeis not set, the worker's dispatch and sandbox config are unchanged. The defensive hook replaces a silent hang with a clear error — strictly an improvement, not a change to working code.Why?
breakpoint()andpdb.set_trace()inside workflow code silently hang today. Three overlapping issues:ThreadPoolExecutorthread, so pdb'sinput()can't read the controlling TTY.breakpointas non-deterministic, so the call doesn't reach the debugger.cmdlooptouches more sandbox-restricted internals at runtime (e.g.readline.get_completer) — relaxing the builtin alone isn't enough.Direct synchronous activation from the dispatch coroutine doesn't work on Python 3.14:
The dispatch task is mid-
__step()whenworkflow.activatetries to step the workflow's own task; 3.14 refuses.await futureafterloop.call_soonsuspends the dispatch task first.Complements temporalio#1249 (sandbox passthrough for IDE debuggers). Independent change, different debugger.
Checklist
Closes Setting debug_mode in a Worker still doesn't allow the user of breakpoints temporalio/sdk-python#1104
How was this tested:
tests/worker/test_breakpoint_hang.py— five tests covering thread placement (both modes), breakpoint in a sandboxed workflow lands at the user's frame with locals visible,q/Ctrl-D continues cleanly, defensive hook raises. 5/5 pass on Python 3.13 and 3.14.breakpoint()into any workflow'srun()body, run viapytest -s(or a standalonepythonscript), confirm the(Pdb)prompt opens at the user's frame with locals in scope.breakpoint()/pdb" subsection to the README under Workflow Sandbox, with a runnable example and the workflow-task-timeout caveat.