Internal: Suppress Hello Pro banner when Elementor Core is active [TMZ-1072]

[Ntnelbaba]

Summary

• Stop enqueueing the Hello theme conversion banner when Elementor Core is active (or Pro is installed), since Core already shows its own upgrade notice
• Remove the duplicate "Build more with Elementor Pro" welcome config from the Hello admin REST API when Core is present
• Update Playwright coverage to assert the Hello banner does not mount on admin list pages with Core active

Jira

TMZ-1072 — Pro banner is duplicated when Core and Hello exists

Test plan

• With Hello Theme + Elementor Core (free): confirm only Core's #e-conversion-banner appears on WP admin pages (e.g. Pages list, Plugins), not Hello's #ehe-admin-cb
• With Hello Theme only (Elementor not active): confirm Hello still shows the install/activate Elementor welcome banner
• With Elementor Pro installed: confirm neither Pro upgrade banner appears from Hello
• Run Playwright: conversion-banner-layout.test.ts

✨ PR Description

1. Problem & Context

Suppress the Hello Pro upsell banner when Elementor Core is active—currently the banner only hides when Pro is installed AND Core is active, but should hide for either condition (ED-24302).

2. What Changed (Where)

• conversion-banner.php: Changed condition from AND to OR—now suppresses banner if Pro exists OR Core is active
• admin-config.php: Removed hardcoded Pro upsell welcome box and $has_pro variable entirely
• conversion-banner-layout.test.ts: Updated test to reflect new behavior; simplified mock setup

3. How It Works

Entry point is is_conversion_banner_active(). Previously required both has_pro() && is_elementor_active() to suppress; now requires only one condition met. Upsell content in admin-config.php is now unconditionally removed for active Elementor installs, delegating suppression logic to the banner component.

4. Risks

None—logic is more permissive (shows fewer banners), and is_elementor_active() is an existing utility. Test changes are straightforward and cover the actual behavior now.

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how}

[github-actions]

Hello Elementor Build

Last updated at: 20260824.1205
Version: 3.4.9

✅ Hello Elementor build is ready for download.

You can download the latest build from the link below:

🔗 hello-elementor.3.4.9.zip

The build is available for 7 days.