Fix: Improve keyboard navigation for Accessibility Ready compliance - #686
Merged
Conversation
Hello Elementor BuildLast updated at: 20260824.1559 ✅ Hello Elementor build is ready for download. You can download the latest build from the link below: The build is available for 7 days. |
arielk
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Improving keyboard accessibility for WCAG 2.1 AA compliance. Adds visible focus indicators and fixes keyboard navigation for dropdown menus and mobile nav toggles.
2. What Changed (Where)
.site-navigation-dropdownovershoot)aria-expandedandesc_attr__()to mobile nav toggle button for keyboard state tracking_focus.scsswith global:focus-visibleoutline (2px black + 4px white glow) supporting light/dark backgroundsinset-*), added dropdown positioning fixes, removed focus-only rules from forms, addedoverflow-x: clip/hiddenfor full-width alignments3. How It Works
Mobile menu button now announces expanded state via ARIA. Global focus ring applies to all interactive elements with 3:1 contrast guarantee. Dropdown menus repositioned to logical properties (RTL-compatible), with special handling for bottom-aligned items. Full-width Gutenberg blocks constrained via viewport overflow controls.
4. Risks
Focus ring color (#000 + #fff) assumes sufficient page contrast; test on colorful backgrounds. Dropdown positioning logic (
inset-inline-start: auto; inset-inline-end: 0on last/second-last) may conflict with RTL transforms—verify in RTL context.aria-expandedrequires JS to toggle; verify implementation elsewhere.Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how